FormidableLabs / FormidableLabs/spectacle

Create a util to more concisely parse query params

Open
#810 2 comments 0 reactions 0 assignees View on GitHub
Nice to Have
Dominant language
TypeScript
Stars
10.2k
Forks
700
PR merge metrics
No merged PRs in 30d

Description

[regarding v6]

Currently, there are two issues with the way we are parsing query params:

1. Users need to pass `=true` to query params for them to take hold, i.e. `localhost:3000/?presenterMode=true`
2. Location matters, so a user cannot append their URL with `presenterMode=true`, it has to come immediately after the localhost, before any other `slideElements` are tacked on

We should handle this differently. In addition to parsing these in a cleaner way, we should add support for (listed in priority order):

- `?presenter`
- `?overview`
- `?export`
- `?print`
- `?export&print`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.