FormidableLabs / FormidableLabs/spectacle

spectacle-mdx-loader: MDX component map lacks a lot of things that Markdown supports

Open
#1,232 0 comments 0 reactions 0 assignees View on GitHub
🐛 Bug
Dominant language
TypeScript
Stars
10.2k
Forks
700
PR merge metrics
No merged PRs in 30d

Description

We have a discrepancy in code blocks in MD vs. MDX and likely other Spectacle core component support.

## Example

For our MD example with `pnpm start:md` for the code page we have:

![Screen Shot 2022-09-21 at 1 50 03 PM](https://user-images.githubusercontent.com/445557/191608036-7619273d-bba6-4b42-83e5-8f8132c317b7.png)

For our MDX example with `pnpm start:mdx` for the code page with exact same sample we have:

![Screen Shot 2022-09-21 at 1 50 08 PM](https://user-images.githubusercontent.com/445557/191608085-cd5a775e-0ed1-4b4d-9a4e-9d52a64a9ef7.png)

## Cause

Our `Markdown` component and related components do a **lot** more things than our `mdxComponentMap` does that we pass into MDX.

## Work

See if we can expand `mdxComponentMap` to something more general that ideally doesn't rejigger core Spectacle too much.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.