FormidableLabs / FormidableLabs/react-native-app-auth

Support for response mode is missing

Open
#917 1 comment 1 reaction 0 assignees View on GitHub
enhancement issue-accepted on hold third-party
Dominant language
Java
Stars
2.3k
Forks
473
PR merge metrics
No merged PRs in 30d

Description

## Issue
Support for response mode is missing. If you try to add it as an additional parameter:

```js
import {authorize} from 'react-native-app-auth';

const appleConfig = {
issuer: 'https://appleid.apple.com',
clientId: APP_CONFIG.appleClientId,
redirectUrl: APP_CONFIG.appleRedirectURI,
scopes: ['name', 'email'],
additionalParameters: {
response_mode: "form_post",
}
};
let result = await authorize(appleConfig);
```

[You get this error](https://github.com/openid/AppAuth-Android/blob/c6137b7db306d9c097c0d5763f3fb944cd0122d2/library/java/net/openid/appauth/AdditionalParamsProcessor.java#L63):
>Parameter response_mode is directly supported via the authorization request builder, use the builder method instead

Please add a `responseMode` parameter to config. In RNAppAuthModule.java, use `setResponseMode()` to pass that on. A similar change is needed for iOS.

This may also require an upstream fix in `net.openid.appauth.AuthorizationRequest` to support `form_post`.

## Related issues
Implement "form_post" response mode https://github.com/FormidableLabs/react-native-app-auth/issues/580
Has anyone used this lib for Apple Sign In (on Android)? https://github.com/FormidableLabs/react-native-app-auth/issues/484

## Environment

* **Your Identity Provider**: `Apple`
* **Platform that you're experiencing the issue on**: `Android `
* **Your `react-native` Version**: `0.72.6`
* **Your `react-native-app-auth` Version**: `7..1.0`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.