FormidableLabs / FormidableLabs/react-native-app-auth

The app crashes if iosCustomBrowser is not provided, react-native 0.77.1

Open
#1,061 11 comments 2 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.3k
Forks
473
PR merge metrics
No merged PRs in 30d

Description

## Issue

The release configuration of the app crashes on iOS if **authorize** method is called _without_ **iosCustomBrowser** option. It reproduces only with react-native v0.77.1.

```
- (id)getCustomBrowser: (NSString *) browserType {
typedef id (^BrowserBlock)(void);

NSDictionary *browsers = @{
@"safari":
^{
return [OIDExternalUserAgentIOSCustomBrowser CustomBrowserSafari];
},
@"chrome":
^{
return [OIDExternalUserAgentIOSCustomBrowser CustomBrowserChrome];
},
@"opera":
^{
return [OIDExternalUserAgentIOSCustomBrowser CustomBrowserOpera];
},
@"firefox":
^{
return [OIDExternalUserAgentIOSCustomBrowser CustomBrowserFirefox];
}
};
BrowserBlock browser = browsers[browserType];
return browser(); <-- Thread 1: EXC_BAD_ACCESS (code=1, address=0x10)
}
```

---

## Environment

* **Your Identity Provider**: IdentityServer 4
* **Platform that you're experiencing the issue on**: iOS (only release configuration)
* **Your `react-native` Version**: 0.77.1
* **Your `react-native-app-auth` Version**: 8.0.0
* **Are you using Expo?**: 52.0.35

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.