FormidableLabs / FormidableLabs/react-live
pre-defined style fontFamily breaks Prism theme
Open
- Dominant language
- TypeScript
- Stars
- 4.6k
- Forks
- 260
- PR merge metrics
- No merged PRs in 30d
Description
Line 51 `fontFamily: "inherit"`
https://github.com/FormidableLabs/react-live/blob/e21fd338e61641b1960d1f3650d6ba7482ceae03/src/components/Editor/index.js#L48-L51
Will override Prism theme
https://github.com/PrismJS/prism/blob/0d4b6cb64e72a172fc64423c04aed4ac8b59cd0b/themes/prism.css#L12
Further, why not let users define all the style (margin, outline, padding, fontFamily) by themself through `className`? This way, React Live will become a true HeadlessUI component.
Contributor guide
Assessment
This issue has not been assessed yet.