FormidableLabs / FormidableLabs/nuka-carousel

renderAccounceSlideMessage() is not a function error after React 19 upgrade

Open
#1,104 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3.1k
Forks
588
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

### Code Sandbox link

_No response_

### Bug report

```markdown
We're getting a renderAccounceSlideMessage() error when trying to use nuka-carousel 7 in our app.

This appears to be an issue with props in version 7 getting their defaults via `defaultProps` which was fully removed in React 19.

I am happy to make this fix as a back port to version 7 if the maintainers of this library are open to it. I just first wanted to raise the issue and make sure there wouldn't be any objections to such a move.

Nuka-carousel 7 is flagged as being compatible with React >= 18 and this makes it incompatible. We've got an older app with a good number of carousel instances and the jump to version 8 has more breaking changes. So the happy path for us was React 18 -> 19 on nuka-carousel 7. Then move to 8 at a later date but this incompatibility is gumming us up.

Let me know if I can proceed with opening a patch MR and what branch to base a version 7 fix and code edit off of if open to changes.

Thank you!
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.