FormidableLabs / FormidableLabs/inspectpack

Allow CI to pass

Open
#179 1 comment 0 reactions 0 assignees View on GitHub
unverified
Dominant language
TypeScript
Stars
590
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have installed this package in 4.7.1 to keep a track of our duplicates packages, and now the CI fail :

![image](https://user-images.githubusercontent.com/77674046/184821002-9342cfcd-2af7-443c-887a-6f3bd6a88c85.png)
![image](https://user-images.githubusercontent.com/77674046/184821040-6c379999-5805-4825-bc8b-85f5313807ee.png)

This is our configuration in webpack 4 https://github.com/pass-culture/pass-culture-app-native/blob/c703bd08bf949eba64fe282c97034f09d97a3a57/web/config/webpack.config.js#L722-L738

```js
new DuplicatesPlugin({
// Emit compilation warning or error? (Default: `false`)
emitErrors: false,
// Handle all messages with handler function (`(report: string)`)
// Overrides `emitErrors` output.
emitHandler: undefined,
// List of packages that can be ignored. (Default: `[]`)
// - If a string, then a prefix match of `{$name}/` for each module.
// - If a regex, then `.test(pattern)` which means you should add slashes
// where appropriate.
//
// **Note**: Uses posix paths for all matching (e.g., on windows `/` not `\`).
ignoredPackages: undefined,
// Display full duplicates information? (Default: `false`)
verbose: true
})
```

I would expect `emitErrors` to prevent the CI to fail.

How can I allow the CI to pass ? Can this be a futur feture ?

Thanks for sharing !

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.