ForNeVeR / ForNeVeR/xaml-math

Refactor C#-defined command system

Open
#157 3 comments 0 reactions 0 assignees View on GitHub
kind:feature kind:refactoring
Dominant language
C#
Stars
719
Forks
113
Avg merge
6d 12h
Merged PRs (30d)
1

Description

For now, when defining a command in C# code, I need to add it to two places:
1. `TexFormulaParser.commands` hash set.
2. `TexFormulaParser.ProcessCommand` method.

It looks like a lot of duplication comes from this, and also this system is not user-extendable.

What I imagine is the following:

1. We need to declare one command dictionary, no name duplication should ever be used.
2. Create a `TexCommand` class and allow the implementation to deal with parsed arguments etc.
3. Add an external `RegisterCommand` API for our users to define their own commands in C#.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.