ForNeVeR / ForNeVeR/Hammerfest

Support several DNS overrides at once

Open
#13 0 comments 0 reactions 1 assignee Assigned to @bookuha View on GitHub
enhancement
Dominant language
C#
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Currently, `DnsService` only overrides the DNS entry for the ServServ hostname.

In #4, we found that there are several various entries.

So, I propose the following changes.

1. Support overriding of several entries at once in `DnsService`.
2. Support proper rollback of said change (i.e. it should remove all the added entries and replace all the _changed_ ones in the `StopServer` function).
3. It should be done efficiently, in one disk write operation.
4. Add unit tests verifying the new behavior.

You can start work from my dirty changes in branch `feature/multi-dns-override`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.