FolkComputer / FolkComputer/folk

Properly fix the assignment of Control characters in keymap.tcl

Open
#170 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
298
Forks
28
PR merge metrics
No merged PRs in 30d

Description

https://github.com/FolkComputer/folk/commit/ab1541b59896448b2e57af272e0b097ec7f4e843 fixes this issue but feels like a hack. I have a hunch that the proper fix is to avoid adding `Control_*` characters to the list of chars or modifying `resolve` directly but I can't grok or debug it well tonight.

https://github.com/FolkComputer/folk/blob/b410c0678a56901fe62019110460334508bb3408/lib/keymap.tcl#L214-L224

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.