Fmstrat / Fmstrat/easywildcard

Fails if we don't have two challenges

Open Beginner friendly
#8 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
55
Forks
10
PR merge metrics
No merged PRs in 30d

Description

Hi

I'm a very happy user of easywildcard.

For a couple of domains I seen this error

```
Some challenges have failed.
IMPORTANT NOTES:
- The following errors were reported by the server:

Domain: smtp.no.ist.com
Type: dns
Detail: DNS problem: SERVFAIL looking up TXT for
_acme-challenge.smtp.no.ist.com - the domain's nameservers may be
malfunctioning
```
when running `docker run -v /etc/letsencrypt/:/etc/letsencrypt --rm -i -e "EMAIL=email@example.net" -e "DOMAIN=smtp.no.ist.com" easywildcard`

The reason is certbot only gets one challenge, and bind is only startet if there are two challenges, due to https://github.com/Fmstrat/easywildcard/blob/master/hooks/auth-hook.sh's `if [ $NUM -eq 2 ]`

My workaround is to run `docker run -v /etc/letsencrypt/:/etc/letsencrypt -v /tmp/:/tmp --rm -i -e "EMAIL=email@example.net" -e "DOMAIN=smtp.no.ist.com" easywildcard` twice ... this way /tmp/easywildcard/VALIDATION will contain two challanges and bind will start.

Please replace `if [ $NUM -eq 2 ]` with `if [ $NUM -ge 1 ]`

Have a nice day.
Greetings, Christian

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in hooks/auth-hook.sh and inspect the NUM check that controls when bind starts. Reproduce the single-challenge Docker invocation from the issue, update the condition so one or more challenges start bind, and verify that the validation succeeds without running the container twice.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.