FlowFuse / FlowFuse/node-red-dashboard

Inclusion of a zero sized template node in a group alters its size.

Open
#1,098 4 comments 0 reactions 0 assignees View on GitHub
needs-triage type:bug
Dominant language
HTML
Stars
355
Forks
82
Avg merge
4d 20h
Merged PRs (30d)
24

Description

### Current Behavior

Initially found this bug when constructing a sub flow with a gauge and a template node. White space appeared above the gauge when displayed on the dashboard. Removing the template node removed the whitespace. The template node size was set to width 0 and height 0. The same behaviour was observed when the gauge and template nodes were removed from the subflow and placed in a flow (although in this case the white space was below the gauge). The template node size is set to auto as zero size is not an available option. This behaviour is observed even when the template node is empty, with no code in it.
![Image 15-07-2024 at 14 16](https://github.com/user-attachments/assets/a7d727e9-9719-4ed4-bda2-825f96f3888e)

### Expected Behavior

Inclusion of a zero sized template node in a group should not alter its size.

### Steps To Reproduce

[flows-2.json](https://github.com/user-attachments/files/16235114/flows-2.json)

### Environment

- Dashboard version: 1.13.0
- Node-RED version: 4.0.0.
- Node.js version: v18.20.3
- npm version: 10.7.0
- Platform/OS: Raspberry Pi Debian version: 12 (bookworm)
- Browser: Safari and Chrome

### Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by importing the attached flows-2.json in the Dashboard and compare the group dimensions with and without the empty template node, reproducing the extra whitespace in the reported environments. The work is done when a zero-sized template node no longer changes the group's size or adds whitespace around the gauge.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, nodejs
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.