FlowFuse / FlowFuse/node-red-dashboard

ui_button stores the msg sent to it.

Open
#1,041 3 comments 0 reactions 0 assignees View on GitHub
needs-triage type:bug
Dominant language
HTML
Stars
355
Forks
82
Avg merge
4d 23h
Merged PRs (30d)
24

Description

### Current Behavior

When i send a message to to a ui_button - it stores the message.
(Irrespective of "if msg arrives on input, emulate a button click" option ).
I inject message with msg.X = , msg.Y=2 , msg.topic = 3.
I override the topic as part of button definition. Yet on button click in get msg.X=1,msg.Y=2.

Not clear why user message would be stored in the button. If there are multiple users it may create a situation of multiple messages being stored. (not sure).

This looks like potential memory leak.

### Expected Behavior

In DB1 - ui_button doesnt store the msg.
In DB2 - as well - cannot see a reason why one would want ui_button node to store the msg sent to it.

### Steps To Reproduce

_No response_

### Environment

- Dashboard version:1.12.2
- Node-RED version: .3.1.9
- Node.js version:20.10.0
- npm version:10.2.3
- Platform/OS:Windows
- Browser:Chrome

### Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.