FlowFuse / FlowFuse/flowfuse

Teams without the emailAlerts feature can setup alerts if they access the url dirrectly

Open
#5,357 0 comments 0 reactions 0 assignees View on GitHub
needs-triage type:bug
Dominant language
JavaScript
Stars
400
Forks
89
Avg merge
1d 21h
Merged PRs (30d)
146

Description

### Current Behavior

While teams without the `team.type.properties.features.emailAlerts` feature enabled can't access the instance alert settings via the ui, they can do so by accessing the url dirrectly. Once there they can set alerts unimpeded.

There should be backend checks for the team feature state to prevent this.

### Expected Behavior

Teams without the emailAlerts feature enabled should not be allowed to set alerts even if they access the ui

### Steps To Reproduce

access an instance's alerts settings url dirrectly `/instance//settings/alerts` that's part of a team that doesn't have the emailAlerts feature enabled and setup alerts

### Environment

- FlowFuse version: 2.15.0
- Node.js version: N/A
- npm version: N/A
- Platform/OS: N/A
- Browser: N/A

### Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.