FlowFuse / FlowFuse/flowfuse

release-publish.yml out of date

Open
#1,377 2 comments 0 reactions 0 assignees View on GitHub
needs-triage
Dominant language
JavaScript
Stars
400
Forks
89
Avg merge
1d 20h
Merged PRs (30d)
149

Description

### Description

Missing entry `access: public` in https://github.com/flowforge/flowforge/blob/main/.github/workflows/release-publish.yml

#### currently...
`jobs > publish > steps > uses: JS-DevTools/npm-publish@v1 > with` does not have `access: public`
```yaml
jobs:
publish:
steps:
- uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_PUBLISH_TOKEN }}
```

#### required...
add `access: public` below `token` in `jobs > publish > steps > uses: JS-DevTools/npm-publish@v1 > with`
```yaml
jobs:
publish:
steps:
- uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_PUBLISH_TOKEN }}
access: public
```

Although this does not cause an issue for this repo, it is linked to as an example [in the handbook > development > packaging> release-publish](https://flowforge.com/handbook/development/packaging/#release-publish) page...

> Release Publish
> For any repositories that contain modules to be published to npm, they should also have a copy of .github/workflows/release-publish.yml.

However, without this entry, new repos are not published to npm on first tag.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.