FlowFuse / FlowFuse/driver-localfs

Improve shutdown handling on Windows

Open
#79 0 comments 0 reactions 0 assignees View on GitHub
task
Dominant language
JavaScript
Stars
3
Forks
4
Avg merge
1d 17h
Merged PRs (30d)
7

Description

### Description

_Originally raised in https://github.com/flowforge/flowforge-nr-launcher/pull/111#pullrequestreview-1414516901_

When running on Windows, the localfs driver issues:
```
childProcess.exec(`taskkill /pid ${projectSettings.pid} /T /F`)
```
Which essentially kills the process without ever performing a clean shutdown (so non of this code is ever executed by the launcher)

A possible future "fix" (also perhaps an improvement?) might be to utilise ipc or pipe and use process.send to tell the launcher to "shutdown" before any kill operation. This would permit a chance to verify the "shutdown" actually occurs and an opportunity to grab logs entries on the shutdown process.

### Epic/Story

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.