Flipboard / Flipboard/react-canvas

Group does not apply position styles to its children

Open
#99 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
13.2k
Forks
909
PR merge metrics
No merged PRs in 30d

Description

The Group component does not apply its left/top style attributes to its children. In the example below, the Group is passed a valid style object with left and top values. The child Text component is rendered at [0,0] instead of being translated by the groups left/right values.

``` coffeescript
Index = React.createClass

render: ->
groupStyle =
top: 100
left: 100
width: 400
height: 400

textStyle =
top: 0
left: 0
height: 20
lineHeight: 20
fontSize: 12
width: 300




I should be indented by 100 top and left



```

The text is rendered without the 100 \* 100 translation.

![reactviz](https://cloud.githubusercontent.com/assets/3643611/8086271/704ff24a-0f49-11e5-9ba4-b7c0a332d809.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.