FlareSolverr / FlareSolverr/FlareSolverr
API logs expose cookies, proxy credentials, and request/response secrets
- Dominant language
- Python
- Stars
- 15.6k
- Forks
- 1.3k
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 3
Description
### Have you checked our README?
- [x] I have checked the README
### Have you followed our Troubleshooting?
- [x] I have followed your Troubleshooting
### Is there already an issue for your problem?
- [x] I have checked older issues, open and closed
### Have you checked the discussions?
- [x] I have read the Discussions
### Have you ACTUALLY checked all these?
YES
### Environment
```markdown
- FlareSolverr version: master at 0f05ed8fc974b215c36892b5a30122e27fe3c671
- Last working FlareSolverr version: unknown
- Operating system: Ubuntu 24.04 (remote deployment inspection)
- Are you using Docker: yes
- FlareSolverr User-Agent (see log traces or / endpoint): not applicable
- Are you using a VPN: no
- Are you using a Proxy: yes
- URL to test this issue: any endpoint sending authenticated cookies or proxy credentials
```
### Description
## Description
The API controller logs the complete request payload at INFO level and the complete response object at DEBUG level. Those structures can contain cookies, headers, passwords, post data, proxy URLs and credentials, response HTML, screenshots, and CAPTCHA tokens. A default deployment can therefore persist secrets in service logs.
## Expected behaviour
Operational logs should retain useful metadata while masking authentication material and sensitive request and response fields.
## Proposed fix
Add a recursive redaction helper for known sensitive keys, use it for incoming request and debug response logs, and preserve only non-sensitive metadata. A focused test verifies that representative secrets do not appear in the logged output.
### Logged Error Messages
```text
No service failure is required; the exposure is visible in normal request logging when sensitive fields are supplied.
```
### Screenshots
_No response_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at the API controller's INFO request-payload and DEBUG response-object logging described in the issue. Identify the sensitive keys and logging paths, add the proposed recursive redaction helper and a focused test, then verify that representative cookies, credentials, tokens, and other secrets do not appear while useful metadata remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100