Flagsmith / Flagsmith/flagsmith
Add E2E coverage for admin API keys
Open
- Dominant language
- Python
- Stars
- 6.6k
- Forks
- 567
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 121
Description
Nothing covers admin/master API keys today. `sdk-keys-test.pw.ts` covers server-side SDK keys, which is a different feature.
We want coverage before refactoring `AdminAPIKeys.js` (#8173), so the suite can be run after review to confirm nothing moved. The file is 565 lines holding two `PureComponent` classes with `static propTypes = {}`, so there is no stated contract to check a refactor against.
Selectors should be role and name, no `data-test` hooks. Two things block that today and are worth fixing anyway: edit is a `
` with an `onClick` (`Row className='list-item'`), so it has no role and cannot be reached by keyboard at all, and delete is an icon-only button with no accessible name. `BareButton` is the canonical clickable surface for the row.
Cover creating a key, editing one, deleting one, adding and removing roles, and the expiry date.
Contributor guide
Assessment
This issue has not been assessed yet.