Flagsmith / Flagsmith/flagsmith

Adopt FieldLabel and FieldError across hand-rolled form labels and errors

Open
#8,120 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
6.6k
Forks
567
Avg merge
1d 14h
Merged PRs (30d)
124

Description

Forms hand-roll `` elements (~87 occurrences across 42 files) and render errors without wiring them to their control, so labels focus nothing and screen readers announce nothing. Replace them with `FieldLabel`/`FieldError` in batches.

First pass: #8117 (the 15 `InputGroup component=` slot sites, which had zero wiring, plus CopyField and DateSelect label wiring). Remaining raw-label sites follow in batches, or as-touched.

Contributor guide

Open the contributing guide

Research direction

Start with #8117 and inspect the 15 InputGroup component= slot sites, plus the CopyField and DateSelect label wiring mentioned in the issue. Compare those sites with the existing FieldLabel and FieldError components; done means the selected batch no longer hand-rolls labels or renders unassociated errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
accessibility, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.