Flagsmith / Flagsmith/flagsmith

UX improvement: Inline editing for identity overrides in Edit Feature modal

Open
#6,903 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
6.6k
Forks
567
Avg merge
1d 13h
Merged PRs (30d)
121

Description

## Problem

In the Edit Feature modal → Identity Overrides tab, clicking "Edit" opens a new browser tab navigating to the identity page. This breaks the user's flow — they lose context of the feature they were editing and have to navigate back.

Image

I understand the intention of avoiding duplicated logic, since this approach keeps identity overrides editable in a single place. However, I thought it would still be worth raising the discussion.

## Proposed improvement

Replace the new-tab navigation with an inline expandable/accordion row within the same modal. Clicking "Edit" would expand the row to show:
- Enabled toggle
- Value editor (with format selector: .txt, .json, .xml, .toml, .yaml)
- Description field
- Save/Cancel buttons

This keeps the user in context and reduces the number of steps to edit an identity override.

**Location**: `web/components/modals/create-feature/index.js` lines 1496–1507

## Acceptance Criteria

- [ ] Clicking "Edit" expands the row inline instead of opening a new tab
- [ ] User can toggle enabled, edit value, and save without leaving the modal
- [ ] Expanded row collapses on save or cancel
- [ ] No regression on the identity page edit flow (direct navigation still works)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.