Flagsmith / Flagsmith/flagsmith

Align change requests permissions between projects and environments

Open
#4,869 3 comments 0 reactions 2 assignees Claimed by @matthewelwell View on GitHub
improvement
Dominant language
Python
Stars
6.6k
Forks
567
Avg merge
1d 13h
Merged PRs (30d)
121

Description

### Is your feature request related to a problem? Please describe.

https://github.com/Flagsmith/flagsmith/issues/4044 raises a disparity between project level and environment level change requests.

With it we have the following permissions which have differences in permission behaviour and terminology

### **Project**

Manage segments
Ability to manage segments in the given project.

Manage project level change requests
Ability to publish, create and delete change requests.

Approve project level change requests
Ability to approve project level change requests.

### **Environment**

Update feature state
Update the state or value for a given feature state. //or publish change requests

Create change request
Permission to create change requests in the given environment.

Approve change request
Permission to approve change requests in the given environment.

### Describe the solution you'd like.

We should have a consistent approach to these permissions:

Option 1:
- Create Change requests: Create change requests
- Approve Change requests: Approve change requests
- Manage segments/Update Feature state - Used to either publish change requests or save the item if change requests are disabled. We should include this in the description

Option 2:
- Manage Change requests: Create and publish
- Approve Change requests: Approve change requests
- Manage X - Only visible if change requests are disabled since they are superseded by change requests

- We should update the mange segment permission description to specify that it means create and update

### Describe alternatives you've considered

Options covered in above

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.