Flagsmith / Flagsmith/flagsmith

"No changes found" shown in already-applied change requests

Open
#4,235 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
6.6k
Forks
567
Avg merge
1d 13h
Merged PRs (30d)
121

Description

### How are you running Flagsmith

- [ ] Self Hosted with Docker
- [ ] Self Hosted with Kubernetes
- [X] SaaS at flagsmith.com
- [ ] Some other way (add details in description below)

### Describe the bug

When viewing a change request or scheduled change, we show a diff of the changes that will be applied:

image

However, after the change request is applied, we show a banner with "No Changes Found":

image

This is misleading as it gives the impression that this change request contains no changes, which should be impossible.

### Steps To Reproduce

1. Schedule a feature to be enabled
2. Publish the change
3. View the scheduled change again

### Expected behavior

A scheduled change's diff should be relative to the state of features at the time the change was created, not to the current state of the feature.

I don't know if this information is stored to begin with, which might be tricky. If that's not possible, we should remove the "No changes found" message altogether.

### Screenshots

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.