Flagsmith / Flagsmith/flagsmith

Create Feature, Create Segment and Edit Segment modals cannot always be closed with Esc

Open
#4,234 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
6.6k
Forks
567
Avg merge
1d 13h
Merged PRs (30d)
121

Description

### How are you running Flagsmith

- [ ] Self Hosted with Docker
- [ ] Self Hosted with Kubernetes
- [X] SaaS at flagsmith.com
- [ ] Some other way (add details in description below)

### Describe the bug

Haven't found a pattern, but sometimes the Create Feature, Create Segment and Edit Segment modals cannot be closed using the Escape key.

### Steps To Reproduce

Randomly open and close modals until you can't close them with Esc anymore:

https://github.com/Flagsmith/flagsmith/assets/829698/646bb1c8-940b-4054-bbdb-0296ca076fb0

https://github.com/Flagsmith/flagsmith/assets/829698/df78afc4-1d57-4124-a982-ad919f2249fb

### Expected behavior

All modals should always be closable using Escape.

### Screenshots

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.