Flagsmith / Flagsmith/flagsmith-go-client

Errors are not wrapped with %w

Open
#123 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
16
Forks
16
Avg merge
8h 32m
Merged PRs (30d)
1

Description

Errors like:
```
return Flags{}, &FlagsmithAPIError{msg: fmt.Sprintf("flagsmith: error performing request to Flagsmith API: %s", err)}
```
Are not wrapped with `%w` e.g.
```
return Flags{}, &FlagsmithAPIError{msg: fmt.Sprintf("flagsmith: error performing request to Flagsmith API: %w", err)}
```

This makes handling errors like -
```
Failed to fetch flags with error:
flagsmith:
error performing request to Flagsmith API:
Post "https://api.flagsmith.com/api/v1/identities/":
context deadline exceeded (Client.Timeout exceeded while awaiting headers)
```

a challenge. I'm happy to make a PR there's 5 places.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.