Flagsmith / Flagsmith/flagsmith-flutter-client

Crashlytics reporting a crash when the user lost the internet connection

Open
#63 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
17
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Hi everyone,

When the `enableAnalytics` is enabled if the user had the app opened but out of the sudden lost the internet connection, the syncing method will throw an error that is not caught anywhere and thus reports a crash.

I believe that we should not throw the error and instead just log it. What do you think about it?

In the meantime, I'll disable the analytics to avoid any crashes.

https://github.com/Flagsmith/flagsmith-flutter-client/blob/284bab1dadf54e0782c89f3b1fa43a5c27e67fd1/lib/src/flagsmith_client.dart#L95

Screenshot 2024-08-02 at 10 22 15

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at lib/src/flagsmith_client.dart around line 95, where the analytics syncing method is linked, and reproduce the behavior with the app offline. Done means losing connectivity while analytics is enabled no longer reports a crash and the error is logged instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.