Flagsmith / Flagsmith/engine-test-data

Spike: Condition value type coercion spec

Open
#44 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
0
Forks
0
Avg merge
4d 22h
Merged PRs (30d)
1

Description

The behaviour of the engine needs to be clarified when comparing context values (traits) to segment condition values.

Different languages handle this in different ways, so we need to agree on a set of rules that are not dependent on any specific language implementation.

The goal is to devise test cases that formalise the in-engine type coercion, and a comprehensive user-facing document that details it.

Some of the questions we should have formal answers to, along with draft answers representing the current behaviour:

Q: How is a null context value treated?
A: Engine evaluates to `false` for all operators except `IS_NOT_SET`.

Q: What is the string representation of a Boolean condition value?
A: `'True', 'true', 'False', 'false'`. Numeric values (`1, 0`) are not expected.

Q: How are numeric values compared?
A: Condition value is coerced to context/trait value type.

Q: How are values compared for the In operator?
A: Condition value is coerced to list of strings. Membership check is performed against a string representation of the context/trait value. Boolean context/trait values are skipped (rule evaluated to `false`).
NOTE: This behaviour is deemed problematic due to contradicting the overall logic of coercing segment condition values to trait values, and lack of uniform decimal/float serialisation across different languages.

Q: How are numbers parsed in regards to system locale?
A: Numbers are always parsed with a period as decimal separator, regardless of region or language settings system or process-wise.

#38 is an attempt to formalise the last answer, which sparked a conversation resulting in this issue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.