Flagsmith / Flagsmith/edge-proxy-rs

PR #1 Review Comments - Follow-up Tasks

Open
#2 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
2
Forks
1
Avg merge
4h 20m
Merged PRs (30d)
1

Description

## Review Comments from PR #1

The following items were raised during code review and should be addressed:

### CI/CD & Docker

- [ ] **Use Depot for Docker builds** (`.github/workflows/docker-publish-image.yml`)
- Suggestion to use Depot to save time and hassle with Docker builds
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2694243406

- [ ] **Publish to quay.io** (`.github/workflows/docker-publish-image.yml`)
- Currently only targeting DockerHub, should also publish to quay.io
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2694246017

- [ ] **Use scratch/distroless for Docker image** (`Dockerfile`)
- Consider using scratch or distroless base image for a truly minimal image
- Reference: https://oneuptime.com/blog/post/2026-01-07-rust-minimal-docker-images/view
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2694802512

### Logging

- [ ] **Implement `enable_access_log` setting** (`src/config/logging.rs`)
- Add support for the `enable_access_log` configuration option
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2695314758

### Data Model

- [ ] **Add `feature_type` to engine metadata** (`src/models/response.rs:30`)
- Currently `feature_type` is hardcoded as "STANDARD"
- Consider adding `feature_type` to the flag engine metadata so it can be properly populated
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2695328341

### Performance

- [ ] **Stress test LRU cache** (`src/cache/endpoint.rs`)
- Investigate how many environments can be cached before `RwLock` becomes a bottleneck
- Consider alternative caches like `threadsafe-lru` or `locallru` if needed
- Comment: https://github.com/Flagsmith/edge-proxy-rs/pull/1#discussion_r2694659412

---
*Generated from PR #1 review comments*

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.