FirebaseExtended / FirebaseExtended/rxfire

[Remote config] Should complete observables after emitting values

Open
#90 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
149
Forks
50
PR merge metrics
No merged PRs in 30d

Description

In the `parameter$` helper function you convert the promise to the Observable
![image](https://github.com/FirebaseExtended/rxfire/assets/95917278/b1ad19d1-8968-4779-a1c7-9274ba3f2be0)
As far as the promise emits values only once, we need to complete the observable after getting a value from the promise. We need to add `subscriber.complete();` after [line 31](https://github.com/FirebaseExtended/rxfire/blob/main/remote-config/index.ts#L31)

Or better use `from(ensureInitialized(remoteConfig)).pipe(map(...))`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.