FirebaseExtended / FirebaseExtended/firestore-leaderboards-codelab

The readRank function does not return the correct rank

Open
#4 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5
Forks
6
PR merge metrics
No merged PRs in 30d

Description

The readRank function does not return the correct rank because it is not guaranteed to search from the bucket with the highest score.
Also, in the createScore function, I think count should represent the number of all individual scores under it, but it actually represents the number of buckets under it.
Therefore, if there is another Range under the Range, the count will not be correct.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.