FirebaseExtended / FirebaseExtended/action-hosting-deploy
Bot comment is updated instead of outdated and new one created
- Dominant language
- TypeScript
- Stars
- 809
- Forks
- 232
- PR merge metrics
- No merged PRs in 30d
Description
**Problem**
Comments in GitHub PRs are interspersed with the chronological commit history which indicates which part of the history the comment refers to (usually commits prior to the comment).
On initial deployment with this GitHub Action, the bot comment is created after the SHA of the first successful deployment. Subsequent deployments simply update the comment which does not shift where the comment is in the history. This could lead to confusion.
**Proposed Solution**
Instead of updating the comment with the new SHA and expiry date etc, the comment _should be Hidden and marked as Outdated, and new one created with the new deployments information_. This way, the deployment history is preserved and appears as expected within the GitHub PR UI.
Alternatively, since the only data that changes in the comment is expiry date and SHA, deleting the old comment and creating a new one would also be sufficient IMO.
**Additional Info**
- While the comment itself has edit history it is not as clear as the proposed solution.
- A hidden comment would be present on the page for N-1 successful deployments. Arguably a lot of visual noise.
Contributor guide
Assessment
This issue has not been assessed yet.