FirebaseExtended / FirebaseExtended/action-hosting-deploy

Unable to deploy to target site

Open
#121 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
809
Forks
232
PR merge metrics
No merged PRs in 30d

Description

### Action config

```
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_APP }}'
projectId: my-awesome-project
channelId: live
target: staging
```

### Error message

There's no error if channelId is set to "live". However, if it's removed, I get an error saying "error": "channelID is currently required"

### Expected behavior

I expect the behavior to be the exact same of `firebase deploy --only hosting:staging`. The code should deploy to the target site.

### Actual behavior

If channelId is blank, error
if channelId is live, I get the following success message
```
details_url: 'https://production-app.web.app/',
27
conclusion: 'success',
28
output: ***
29
title: 'Production deploy succeeded',
30
summary: '[production-app.web.app](https://production-app.web.app/)'
31
***
```

Which is weird because nothing actually deployed to my production site. It's the exact same. Also, if I go to https://staging-app.web.app (which is connected to my staging target), nothing has changed either

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.