FireDynamics / FireDynamics/propti

Fix bugs in propti_analyse.py

Open
#84 4 comments 0 reactions 1 assignee Claimed by @p-lauer View on GitHub
Dominant language
Python
Stars
17
Forks
127
PR merge metrics
No merged PRs in 30d

Description

# `--best_run`

- only simulates one setup, not all of a set
- issues with relative path of model executable (one level higher than optimization)
- sometimes fills model file with nan values

# `--plot_best_sim_exp`

- x,y offset and scaling factors from relations need to be included for plotting (done)
- File "../propti/propti_analyse.py", line 661, in
pr.plot_best_sim_exp(s, pickle_file)
File "/p/project/cjjsc27/MaCFP/MaCFP2020_April/IMP_Runs/propti/propti/propti_post_processing.py", line 397, in plot_best_sim_exp
n_colors=lr)
File "/p/project/cjjsc27/MaCFP/MaCFP2020_April/IMP_Runs/propti/propti/propti_post_processing.py", line 100, in plot_template
ax.set_color_cycle([colormap(k) for k in np.linspace(0, 1, n_colors)])
AttributeError: 'AxesSubplot' object has no attribute 'set_color_cycle'
- naming convention for plots needs to be changed

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.