FireDynamics / FireDynamics/propti
General Version Check of Simulation Software
- Dominant language
- Python
- Stars
- 17
- Forks
- 127
- PR merge metrics
- No merged PRs in 30d
Description
For now we have the version call hardcoded for FDS. That lead to us to realise that we needed to change line (https://github.com/FireDynamics/propti/blob/8b51265118afb786e0b24ec3d8c74cc492fd6d0c/propti/data_structures.py#L731) to enable the execution of newer FDS versions with MPI in the HPC environment, specifically FDS 6.7. We could get arround the rigid approach when calling the `model.executable` out of the `pickle.init` directly.
However, when people want to use different software, not FDS, the version call will propably fail completly, because of the way that we parse the FDS output to retrieve the version number.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with propti/data_structures.py at line 731 and trace how model.executable and pickle.init are used for version checks. Review the FDS output parsing path and determine how version retrieval should work for newer FDS releases and non-FDS software. Done means the version check no longer depends exclusively on FDS-specific output parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100