FireDynamics / FireDynamics/ARTSS
Refactor: Change for all bounday conditions the usage of field.data to field
Open
effort: middle
priority: medium
type: enhancement
type: refactoring
- Dominant language
- C++
- Stars
- 14
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
With the new changes, it may make more sense to give the boundary conditions also Fields as parameters and not their data array. (With regard to the changes in #124 )
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading the boundary-condition code and issue #124, then locate every use of field.data in boundary-condition handling. Determine how those parameters currently receive data arrays and update the design so all boundary conditions use Fields instead; the work is done when all such usages are converted consistently and the existing simulation checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100