FiloSottile / FiloSottile/homebrew-gomod

Thoughts on using go install ?

Open
#7 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
68
Forks
3
PR merge metrics
No merged PRs in 30d

Description

First off this script is super useful to keeping a tidy install of local go tools, thanks! This is a question, since functionally this doesn't seem to matter yet. When using `brew gomod golang.org/x/tools/gopls@latest`

This warning message is shown in recent versions of go:
```
go: creating new go.mod: module gomod-gopls/2022-02-06
go get: installing executables with 'go get' in module mode is deprecated.
To adjust and download dependencies of the current module, use 'go get -d'.
To install using requirements of the current module, use 'go install'.
To install ignoring the current module, use 'go install' with a version,
like 'go install example.com/cmd@latest'.
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
...
```

Have you looked at changing https://github.com/FiloSottile/homebrew-gomod/blob/master/brew-gomod#L36 ? Any reasons not to?

Contributor guide

Open the contributing guide

Research direction

Start at brew-gomod#L36 and inspect how the command invokes Go for `brew gomod golang.org/x/tools/gopls@latest`. Read the Go install deprecation guidance and compare the current behavior with versioned `go install`; the work is done when the command installs the requested module without the reported deprecation warning and its existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, shell
Domain
cli, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.