FiloSottile / FiloSottile/cpace

Setup agreement on a "standard form" of CPace for ristretto255 and add it to the I-D

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
29
Forks
1
PR merge metrics
No merged PRs in 30d

Description

>Simply concatenating variable-length, possibly attacker controlled values as the
>I-D suggests is dangerous. For example, the (idA, idB) pairs ("ax", "b") and
>("a", "xb") would result equivalent. Instead, this implementation uses HKDF to
>separate secret material, salt, and context, and a uint16-length prefixed
>serialization for CI.
Thank's for pointing this out.

Checking for the neutral element should be manadtory in my perception and should be explicitly included into the code, even if some part of the ristretto implementation also checks for this.

Regarding the SID agreement, the recommended way would be that the SID is passed to CPace by a higher-level protocol entity, e.g. on the application level. The implementation is then guaranteed that the specific CPace run is uniquely linked to this session on both sides. This avoids problems in the style of the "selfie-attack" on TLS with PSK.

If there is no such higher-level SID handling, one could just make the initiator sample a random string of appropriate length, e.g. 16 bytes.

I'd appreciate any feedback regarding the readability and structure of the CPace I-D. I don't have much experience with writing this type of document, and any feedback would be helpful.

Yours,

Björn.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.