FilledStacks / FilledStacks/smart_flare

onAreaTapped ran even though the guardComingFrom prevented the animation

Open
#3 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
89
Forks
14
PR merge metrics
No merged PRs in 30d

Description

It would make so much more sense if the developer doesn't have to make the same check that you have already made to prevent the playing of the animation.
I'm using code from your tutorial:
ActiveArea(
area: Rect.fromLTWH(
animationWidthThirds * 2,
0,
animationWidthThirds,
halfAnimationHeight,
),
guardComingFrom: ['deactivate'], //this helps to control the animation itself
animationName: 'image_tapped',
onAreaTapped: () { //makes no sense to call this function
print('Picture!'); //if you don't play the animation
},
),

I hope my suggestion makes sense and the outcome improves this awesome library!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.