FilOzone / FilOzone/filecoin-pay

When decreasing lockup, `modifyRailLockup` first performs `settleAccountLockup`

Open
#290 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Solidity
Stars
8
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Suppose the operator attempts to `modifyRailLockup` to reduce the `lockupPeriod`. I think we only need to do `settleAccountLockup` after and not before.

The impact is that if a user has enough funds for the `lockupPeriod` after but not before the modification, the operation will revert.

I think the same problem also applies to `modifyRailPayment`.

I think that we only really need to `settleAccountLockup` after the operation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.