FilOzone / FilOzone/filecoin-pay

Informational Audit Recommendations

Open
#285 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
8
Forks
13
PR merge metrics
No merged PRs in 30d

Description

These are the best practices recommendations coming out of the composable audit
1. Remove unused errors `OnlyRailParticipantAllowed` and ` FeeWithdrawalNativeTransferFailed` from Errors.sol
2. Use custom errors instead of revert strings. In particular RateChangeQueue is where we are doing this.
3. Clear `serviceFeeParticipant` from rail struct when zeroing out rail -- I believe this one actually has some state usage impact since FVM is smart enough to release KAMT slots that point at zero values and we are not correctly zeroing out rail struct values as we intended
4. Update solidity version to 0.8.33 -- Im not sure the state of FEVM support but I think we should be mostly current thanks to filb's work
5. > Update the NatSpec comment at L1144 to correctly identify the caller as payer.

These are all items we should address whenever we deploy a new version.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.