Ferrite-FEM / Ferrite-FEM/Ferrite.jl

Relax error for 'function integrate_projected_dbc!(::HcurlConformity, Kᶠ, fᶠ, bc_fun, fv, shape_nrs, cell_coords, time)'

Open
#1,203 2 comments 0 reactions 1 assignee Claimed by @KnutAM View on GitHub
enhancement
Dominant language
Julia
Stars
453
Forks
115
Avg merge
1d 17h
Merged PRs (30d)
11

Description

I was trying out the 3D Nedelec elements in the new ferrite version. The function `function integrate_projected_dbc!(::HcurlConformity, Kᶠ, fᶠ, bc_fun, fv, shape_nrs, cell_coords, time)` has ` throw(ArgumentError("ProjectedDirichlet is not implemented for 3D H(curl) conformity"))`. I tested commenting out the error, and I got correct results using zero-Dirichlet boundary conditions. Can this ArgumentError be removed, or be changed to warning instead?

I also think the ProjectedDirichlet docs should be updated, as it appears the required function signature is: `bc_fun(x, time, n)`, but the docs implied to me that a function `fun(x,time)` should be used. It seems that `bc_fun` could be implicitly created as `bc_fun(x, time, n) = cross(n, fun(x,time))` in the projected Dirichlet implementation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.