Ferrite-FEM / Ferrite-FEM/Ferrite.jl

Use of Integer instead of Int

Open
#1,157 6 comments 0 reactions 0 assignees View on GitHub
performance
Dominant language
Julia
Stars
453
Forks
115
Avg merge
1d 17h
Merged PRs (30d)
11

Description

Currently, several core data structures in `Ferrite` use `Int` explicitly for numerical types. For example:

```julia
struct Line <: AbstractCell{RefLine}
nodes::NTuple{2, Int}
end

struct QuadraticLine <: AbstractCell{RefLine}
nodes::NTuple{3, Int}
end

mutable struct SubDofHandler{DH} <: AbstractDofHandler
const dh::DH
const cellset::OrderedSet{Int}
const field_names::Vector{Symbol}
const field_interpolations::Vector{Interpolation}
const field_n_components::Vector{Int}
ndofs_per_cell::Int
end

mutable struct DofHandler{dim, G <: AbstractGrid{dim}} <: AbstractDofHandler
const subdofhandlers::Vector{SubDofHandler{DofHandler{dim, G}}}
const field_names::Vector{Symbol}
const cell_dofs::Vector{Int}
const cell_dofs_offset::Vector{Int}
const cell_to_subdofhandler::Vector{Int}
closed::Bool
const grid::G
ndofs::Int
end
```

The issue is for other code that uses Ferrite and wants to use (e.g. `Int32` or `Int16`), it's a bit cumbersome, and it's impossible in Cell types.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.