FedML-AI / FedML-AI/FedML

In Fed-ML HE example, the client model weights are not encrypted.

Open
#2,124 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4.1k
Forks
765
PR merge metrics
No merged PRs in 30d

Description

The fedml-he example as implemented [here](https://github.com/FedML-AI/FedML/tree/master/python/examples/federate/cross_silo/mqtt_s3_fedavg_fhe_mnist_lr_example) does not seem to encrypt the model weights (torch tensors are communicated instead of ciphertext) even when the `enable_fhe` flag is `true` in the config file.

I checked the source code [here](https://github.com/FedML-AI/FedML/blob/03e11dfee69a458a9820ec4e05b531a5f935eb2b/python/fedml/core/fhe/fhe_agg.py) and found that on [line 29](https://github.com/FedML-AI/FedML/blob/03e11dfee69a458a9820ec4e05b531a5f935eb2b/python/fedml/core/fhe/fhe_agg.py#L29), the line should be:
```python
if self.is_enabled:
return
```

Is that a mistake or did I interpret the code wrong ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.