FasterXML / FasterXML/jackson-dataformats-binary

[protobuf] create ProtoSchema from descriptor file

Open
#78 3 comments 0 reactions 0 assignees View on GitHub
protobuf
Dominant language
Java
Stars
347
Forks
156
Avg merge
3d 3h
Merged PRs (30d)
22

Description

I would like to create ProtobufSchema objects from the descriptor files instead of proto files. `protoc -o output.desc` can generate the descriptor file `output.desc` by compiling multiple proto files. It's often easier to use the descriptor file than dealing with multiple .proto files. At my work we have fairly complex proto files.

I actually have an [experimental implementation](https://gist.github.com/knoguchi/211f44a2137b5def37fbdc04a6db437e). I used Google's official protobuf-java and [protobuf-dynamic](https://github.com/os72/protobuf-dynamic) to read the descriptor file.

Questions

1. would you consider adding the "ProtobufSchema by descriptor file" feature?
2. if the answer is yes, do you think the above approach is acceptable i.e. use google's official protobuf jars, and this._source being null.
3. If the answer is no, would you add a public constructor that takes a ProtobufMessage argument to the ProtobufSchema so that the 3rd party library can create ProtobufSchema objects without ProtoFile object.

thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.