FarmBot / FarmBot/farmbot_os

[Firmware] Movements retry too many times

Open
#990 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Elixir
Stars
1.2k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

# FarmBot OS version
`8.0.2`

# Behavior
Movements are currently attempted `n^2 + n` times, where `n` is the number of retries selected by the user. FarmBot OS attempts a movement `n + 1` times, and every time FarmBot OS tries a movement, the firmware attempts the movement `n` times.

# Expected
The movement retry mechanism should only be implemented in (one of) the firmware or FarmBot OS.

# Relevant code
https://github.com/FarmBot/farmbot_os/blob/923f02467890177d07d8d96696c4e90956db7358/farmbot_os/lib/farmbot_os/sys_calls.ex#L279

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.