FarmBot / FarmBot/farmbot_os

Sequence Not Found error is not sent back to MQTT RPC Client

Open
#1,496 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
1.2k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

Was playing around with the **`farmbot-js`** package today and noticed that `{:error, "sequence not found"}` cases aren't handled and just display on the FBOS Console log ( via `stderr` ? ) instead of being bundled up and returned to the the RPC Client as other errors are, so my JS program just quietly hangs ⏲️ . . .

There's an argument, I suppose, that I should enumerate all Sequences and check that the desired Sequence Id is available before trying to schedule it for execution, but the race condition there still exists ! ( that sequence can be deleted before I try to schedule it )

Here's the error splashed onto the IEx console 🙁

![image](https://user-images.githubusercontent.com/1224439/175230411-44bff3f0-7d7c-4d0c-8851-a3999642bfb6.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.