FarmBot / FarmBot/farmbot_os

Lua Assertion read_pin always returns 1, making programmatic tool verification unusable

Open
#1,328 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
1.2k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

I believe since upgrading to FBOS 13.0.1 (but uncertain if 100% correlated) my Assertion `read_pin` function always returns one, causing my "tool mount/unmount" sequences to fail and abort the parent sequence.

I had believed my UTM got water inside (I have a Genesis v1.2, so the UTM is two parts), but I took it apart and it wasn't the issue. **Furthermore, manually reading the Tool Verification pin from the Sensors screen has always been proven to be 100% accurate when manually testing it and attaching or detaching a tool by hand.**

Because manually reading the pin works everytime, I can only conclude that recently the `read_pin` function has become bugged.

Here is my implementation:

![image](https://user-images.githubusercontent.com/13388489/111029240-a0742a00-8436-11eb-84b0-8d5b2b851ce2.png)
![image](https://user-images.githubusercontent.com/13388489/111029263-c7caf700-8436-11eb-87b5-43984a6d76ba.png)
![image](https://user-images.githubusercontent.com/13388489/111029277-e4ffc580-8436-11eb-9b18-6ca8ce22871e.png)
![image](https://user-images.githubusercontent.com/13388489/111029284-f0eb8780-8436-11eb-82eb-489d6426c091.png)

Also, please note that the Assertion `IF TEST FAILS` filter is empty and shows nothing when clicked. I'm not sure what was there when I created the sequence, and maybe this is related? The same goes for the Send Message `TYPE` and checkboxes. I'm certain those checkboxes had labels before, for sending messages to email, toast, etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.