FancyInnovations / FancyInnovations/FancyPlugins

Bug: FancyHologram's reload command occationally load nothing.

Open
#78 0 comments 0 reactions 0 assignees View on GitHub
FancyHolograms Priority: Medium Status: Pending Type: Bug
Dominant language
Java
Stars
88
Forks
109
PR merge metrics
No merged PRs in 30d

Description

### In which plugin has the error occurred?

FancyHolograms

### What happened?

FancyHologram's reload command occationally load nothing.

Why this happen:
fancyhologram reload command will call reloadHolograms(). Then reloadHolograms will call unloadHolograms() and loadHolograms(). In unloadHolograms, the task will be sent to Hologram thread but in loadHolograms, it will be executed in Server thread(Current thread). So occationally loadHolograms() will be executed earlier than unloadHolograms(). Finally, no holograms will be loaded.

![Image](https://github.com/user-attachments/assets/2561f90e-8350-472d-b123-687193103a70)
![Image](https://github.com/user-attachments/assets/bd48c12f-31a9-4ed1-a935-db94ea5173e0)

### In which software has the error occurred?

Paper

### Plugin version

2.6.0.144

### Server version

1.21.4

### Relevant log output

```shell

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.