FancyInnovations / FancyInnovations/FancyPlugins

Bug: Fairly high memory allocation

Open
#71 1 comment 0 reactions 0 assignees View on GitHub
FancyHolograms Priority: Medium Status: Pending Type: Bug
Dominant language
Java
Stars
88
Forks
109
PR merge metrics
No merged PRs in 30d

Description

### In which plugin has the error occurred?

FancyHolograms

### What happened?

The plugin allocates 11.8MB per second simply from refreshing the hologram displays. None of my holos are animated. Only one of my displays has a placeholder in it. I'm not sure why the plugin needs to allocate 11mb per second or why it needs to constantly refresh every single display. Also it seems like when the holo is "refreshed", the plugin re-parses all it's text to display the hologram, which should not be how it's done. The already-parsed hologram should be stored in a datastructure to be served to the player. This plugin should be relatively lightweight, but this sort of logic and memory allocation is bulky.

![Image](https://github.com/user-attachments/assets/3f3abd5f-380e-4684-aeb9-89b41b7efc9a)

Here's the spark report I got that from.
https://spark.lucko.me/thxPP7NKpO

### In which software has the error occurred?

Leaf

### Plugin version

2.4.2.135

### Server version

1.21.5

### Relevant log output

```shell

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.