FancyInnovations / FancyInnovations/FancyPlugins

Bug: Disabling FancyNpcs "java.util.concurrent.RejectedExecutionException"

Open
#320 0 comments 0 reactions 0 assignees View on GitHub
Priority: Medium Status: Pending Type: Bug
Dominant language
Java
Stars
88
Forks
109
PR merge metrics
No merged PRs in 30d

Description

### In which plugin has the error occurred?

FancyNpcs

### What happened?

.

### In which software has the error occurred?

Paper

### Plugin version

2.11.0

### Server version

26.2

### Relevant log output

```shell
[07:58:43 INFO]: [FancyNpcs] Disabling FancyNpcs v2.11.0
[07:58:43 ERROR]: Error occurred while disabling FancyNpcs v2.11.0
java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@70b041cd[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@153e5503[Wrapped task = de.oliver.fancyanalytics.logger.FancyLogger$$Lambda/0x000000008c5f7800@7b140a68]] rejected from java.util.concurrent.ThreadPoolExecutor@7d319ac3[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1]
at java.base/java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2032) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:787) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1328) ~[?:?]
at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:125) ~[?:?]
at java.base/java.util.concurrent.Executors$DelegatedExecutorService.submit(Executors.java:696) ~[?:?]
at FancyNpcs-2.11.0.jar//de.oliver.fancyanalytics.logger.FancyLogger.log(FancyLogger.java:117) ~[?:?]
at FancyNpcs-2.11.0.jar//de.oliver.fancyanalytics.logger.ExtendedFancyLogger.log(ExtendedFancyLogger.java:60) ~[?:?]
at FancyNpcs-2.11.0.jar//de.oliver.fancyanalytics.logger.ExtendedFancyLogger.info(ExtendedFancyLogger.java:77) ~[?:?]
at FancyNpcs-2.11.0.jar//de.oliver.fancynpcs.FancyNpcs.onDisable(FancyNpcs.java:350) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:285) ~[paper-api-26.2.build.116-stable.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:236) ~[paper-26.2.jar:26.2-116-37dc545]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugins(PaperPluginInstanceManager.java:160) ~[paper-26.2.jar:26.2-116-37dc545]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugins(PaperPluginManagerImpl.java:97) ~[paper-26.2.jar:26.2-116-37dc545]
at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:540) ~[paper-api-26.2.build.116-stable.jar:?]
at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:606) ~[paper-26.2.jar:26.2-116-37dc545]
at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1028) ~[paper-26.2.jar:26.2-116-37dc545]
at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:909) ~[paper-26.2.jar:26.2-116-37dc545]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1384) ~[paper-26.2.jar:26.2-116-37dc545]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:303) ~[paper-26.2.jar:26.2-116-37dc545]
at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]
```

Contributor guide

Open the contributing guide

Research direction

Start with FancyNpcs.onDisable at line 350 and trace the call into ExtendedFancyLogger and FancyLogger.log at line 117. Reproduce disabling FancyNpcs 2.11.0 on Paper 26.2 and inspect the executor lifecycle. Done means shutdown no longer emits the RejectedExecutionException shown in the log.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.